mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Review Request 51946: Updated test for BadACLNoPrincipal and BadACLDropCreateAndDestroy.
Date Fri, 16 Sep 2016 08:36:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51946/
-----------------------------------------------------------

Review request for mesos, Benjamin Mahler, Greg Mann, and Jiang Yan Xu.


Bugs: MESOS-6181
    https://issues.apache.org/jira/browse/MESOS-6181


Repository: mesos


Description
-------

Two updates:
1) Kill the `{}` in the test case as there is no need to add `{}`,
adding the `{}` will cause the driver decline a non exist offer.
2) If destroy volume failed, we should get the last offer to make
sure that the last offer also contain the volume resource.


Diffs
-----

  src/tests/persistent_volume_tests.cpp c38d8484fbd62b36bf124a96d17c8cae5e51e594 

Diff: https://reviews.apache.org/r/51946/diff/


Testing
-------

make
make check

```
./bin/mesos-tests.sh --gtest_filter="*PersistentVolumeTest.BadACL*/*"  --gtest_repeat=20
```


Thanks,

Guangya Liu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message