mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 51942: Removed scalars() API.
Date Fri, 16 Sep 2016 02:48:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51942/#review149165
-----------------------------------------------------------



Patch looks great!

Reviews applied: [51942]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Sept. 16, 2016, 1:53 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51942/
> -----------------------------------------------------------
> 
> (Updated Sept. 16, 2016, 1:53 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Neil Conway, and Jiang Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This API is not used anymore because of performance issues and
> replaced by `createStrippedScalarQuantity`.
> 
> 
> Diffs
> -----
> 
>   include/mesos/resources.hpp 7ba422d57d47777e058c682df9aa780557782423 
>   include/mesos/v1/resources.hpp add48c7baf8fabf5cc443d60a6c96d2902fc67de 
>   src/common/resources.cpp aa4d6b5af9c24e90cefaa4f4c1ad593966eceb7c 
>   src/v1/resources.cpp 4b66acbba92bc6316fa77ae4dcabce9fab65f7b5 
> 
> Diff: https://reviews.apache.org/r/51942/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message