mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 51886: Added tests for default executor.
Date Thu, 15 Sep 2016 18:25:33 GMT


> On Sept. 14, 2016, 1:41 p.m., Guangya Liu wrote:
> > src/tests/default_executor_tests.cpp, lines 119-123
> > <https://reviews.apache.org/r/51886/diff/1/?file=1498340#file1498340line119>
> >
> >     How about adding another task to the task group?
> 
> Guangya Liu wrote:
>     ```
>     v1::TaskInfo taskInfo1 =
>       evolve(createTask(slaveId, resources, "sleep 1000"));
>     
>     v1::TaskInfo taskInfo2 =
>       evolve(createTask(slaveId, resources, "sleep 1000"));
>     
>     v1::TaskGroupInfo taskGroup;
>     taskGroup.add_tasks()->CopyFrom(taskInfo1);
>     taskGroup.add_tasks()->CopyFrom(taskInfo2);
>     ```

Great suggestion. We would like to do that though when we need it i.e. when we add support
for `LAUNCH/DESTROY` sub containers eventually. For the current code, both the scenarios are
the same.


- Anand


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51886/#review148899
-----------------------------------------------------------


On Sept. 14, 2016, 9:34 a.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51886/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2016, 9:34 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-6077
>     https://issues.apache.org/jira/browse/MESOS-6077
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change adds a basic test to ensure that the basic executor
> sends a TASK_RUNNING update upon launch.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 2dd7913a1477f3c3560be4e2c1450b93fb3afc78 
>   src/tests/default_executor_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/51886/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message