mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anindya Sinha <anindya_si...@apple.com>
Subject Re: Review Request 45966: Offer shared resources to frameworks only if opted in.
Date Thu, 15 Sep 2016 16:45:09 GMT


> On Sept. 7, 2016, 10:09 p.m., Jiang Yan Xu wrote:
> > Can we have a simple allocator test with two frameworks, one framework without the
capability doesn't get allocated the shared resource and the other with the capability gets
it?
> > 
> > Could be in a follow up review.
> 
> Anindya Sinha wrote:
>     Will add this test in a separate review.

Added a test in https://reviews.apache.org/r/51919/


- Anindya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45966/#review148098
-----------------------------------------------------------


On Sept. 7, 2016, 11:55 p.m., Anindya Sinha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45966/
> -----------------------------------------------------------
> 
> (Updated Sept. 7, 2016, 11:55 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4325
>     https://issues.apache.org/jira/browse/MESOS-4325
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a new capability SHARED_RESOURCES that frameworks need to opt
> in if they are interested in receiving shared resources in their
> offers.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 7fbcdf005718ba4d7ec3b02cf70a3fc53d4f4818 
>   include/mesos/v1/mesos.proto 60ec0cce35e5e2d2f4907efadc7ab92680566ef0 
>   src/master/allocator/mesos/hierarchical.hpp 1f5f3801eff6b15914ad4a740479a008530befc5

>   src/master/allocator/mesos/hierarchical.cpp 992031a6fbc89727725071841bd3ab827737d8bd

>   src/tests/hierarchical_allocator_tests.cpp b2179215f3a4c2f4018670e8e54f02e06c39c3b1

> 
> Diff: https://reviews.apache.org/r/45966/diff/
> 
> 
> Testing
> -------
> 
> Tests updated with new capability.
> Tests successful.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message