mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anindya Sinha <anindya_si...@apple.com>
Subject Re: Review Request 51869: Export "reserved_resources" in the agent HTTP endpoint.
Date Thu, 15 Sep 2016 00:10:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51869/#review149001
-----------------------------------------------------------




src/slave/http.cpp (line 985)
<https://reviews.apache.org/r/51869/#comment216530>

    Maybe good to add a comment and/or document regarding what the field `resources` contains...
since it changed from `info.resources()` to `info.resources() + checkointed resources applied`.



src/slave/http.cpp (line 986)
<https://reviews.apache.org/r/51869/#comment216528>

    Add this new field `reserved_resources` in `string Slave::Http::STATE_HELP()`.



src/slave/http.cpp (line 987)
<https://reviews.apache.org/r/51869/#comment216529>

    Add this new field `unreserved_resources` in `string Slave::Http::STATE_HELP()`.


- Anindya Sinha


On Sept. 14, 2016, 6:21 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51869/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2016, 6:21 p.m.)
> 
> 
> Review request for mesos, Anindya Sinha and Neil Conway.
> 
> 
> Bugs: MESOS-6085
>     https://issues.apache.org/jira/browse/MESOS-6085
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Also the 'resource' field now exposes the total resources, which is
> consistent with the same field in the master's /slaves endpoint.
> 
> 
> Diffs
> -----
> 
>   src/slave/http.cpp 67463105d7fa38b2158a64f6994e3dd353a9fcc7 
> 
> Diff: https://reviews.apache.org/r/51869/diff/
> 
> 
> Testing
> -------
> 
> make check. A new test is added in https://reviews.apache.org/r/51870/.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message