mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anindya Sinha <anindya_si...@apple.com>
Subject Re: Review Request 51517: Added MOUNT or PATH disk type in logging resources.
Date Wed, 14 Sep 2016 21:42:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51517/
-----------------------------------------------------------

(Updated Sept. 14, 2016, 9:42 p.m.)


Review request for mesos and Jiang Yan Xu.


Changes
-------

Addressed review comments.


Bugs: MESOS-6060
    https://issues.apache.org/jira/browse/MESOS-6060


Repository: mesos


Description
-------

We also log the disk type (MOUNT or PATH) for each persistent disk as
well as the root path for these disks while logging resources. Note
that this is logged only when source is present, otherwise there is
no additional content logged.


Diffs (updated)
-----

  src/common/resources.cpp f841e91b81975a887e64a76a709708ed7946025f 
  src/tests/resources_tests.cpp f627862870279e5a778aa83e1ddcaa88c27ba1cb 
  src/v1/resources.cpp 4410a8f95ef0ebe6ec7aee38cd47f6f83f863867 

Diff: https://reviews.apache.org/r/51517/diff/


Testing
-------

All tests passed.


Thanks,

Anindya Sinha


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message