mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 51517: Added MOUNT or PATH disk type in logging resources.
Date Wed, 14 Sep 2016 20:59:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51517/#review148967
-----------------------------------------------------------




src/common/resources.cpp (line 1745)
<https://reviews.apache.org/r/51517/#comment216498>

    It would be great if you could avoid using `default` when switching over enum values.
See https://issues.apache.org/jira/browse/MESOS-3754 for some background.



src/v1/resources.cpp (line 1748)
<https://reviews.apache.org/r/51517/#comment216497>

    It would be great if you could avoid using `default` when switching over enum values.
See https://issues.apache.org/jira/browse/MESOS-3754 for some background.


- Benjamin Bannier


On Sept. 9, 2016, 6:26 p.m., Anindya Sinha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51517/
> -----------------------------------------------------------
> 
> (Updated Sept. 9, 2016, 6:26 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-6060
>     https://issues.apache.org/jira/browse/MESOS-6060
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We also log the disk type (MOUNT or PATH) for each persistent disk as
> well as the root path for these disks while logging resources. Note
> that this is logged only when source is present, otherwise there is
> no additional content logged.
> 
> 
> Diffs
> -----
> 
>   src/common/resources.cpp 77ee92193de1f34131f7a86b7d16731c9c3e17e2 
>   src/tests/resources_tests.cpp f627862870279e5a778aa83e1ddcaa88c27ba1cb 
>   src/v1/resources.cpp 4ba5bf87c9b9fef67eeb447a3f3b520f1e81ad77 
> 
> Diff: https://reviews.apache.org/r/51517/diff/
> 
> 
> Testing
> -------
> 
> All tests passed.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message