mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 51625: Refactored `GET_CONTAINERS` Call in v1 Agent API.
Date Wed, 14 Sep 2016 14:54:16 GMT


> On Sept. 12, 2016, 8:19 p.m., Vinod Kone wrote:
> > Can you separate out filtering of containers and the refactor into separate commits?
Ideally do filtering first.
> > 
> > Also, what's the motivation for including containers in GetState? I couldn't get
the motivation from the linked ticket.

hi, @vinodkone, thanks for your review. At first I try to include `GetContainers` in the `GetState`
of agent just as we include `GetAgents` in the `GetState` of master.
But now looks like `GetContainers` is a heavy operation, include it in `GetState` may be what
user do not need. Only the other hand, user always could get it by `GET_CONTAINERS`. How about
let me discard this and https://reviews.apache.org/r/51626/?

For filtering out containers by `frameworksApprover` and `executorsApprover`, I think need
to add it to the `/containers` endpoint as well. Let me post a separate patch for it.


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51625/#review148573
-----------------------------------------------------------


On Sept. 12, 2016, 4:50 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51625/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2016, 4:50 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Jay Guo, Vinod Kone, and Zhitao Li.
> 
> 
> Bugs: MESOS-6124
>     https://issues.apache.org/jira/browse/MESOS-6124
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add a `_getContainers` method to return the containers information in
> Operator API v1 protobuf format and switch `getContainers` to use it
> directly. Then it would be easier to show the containers
> information in the response of `getState` by reusing `_getContainers`.
> Additionally, add supporting to filter containers by `principal` as
> well.
> 
> 
> Diffs
> -----
> 
>   src/internal/evolve.cpp 9ae720cdc22c6bcdd56bc6bb391419c52df446f3 
>   src/slave/http.cpp 2cbf3c57e294f0d47d64915371b4a6bbf9cdfc0a 
>   src/slave/slave.hpp 4add4c0180ea56039e0d5009bad4d9346128bde6 
> 
> Diff: https://reviews.apache.org/r/51625/diff/
> 
> 
> Testing
> -------
> 
> ```
> sudo GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="*AgentAPITest.GetContainers*" --verbose
> [       OK ] ContentType/AgentAPITest.GetContainers/1 (85 ms)
> [----------] 2 tests from ContentType/AgentAPITest (263 ms total)
> 
> [----------] Global test environment tear-down
> [==========] 2 tests from 1 test case ran. (284 ms total)
> [  PASSED  ] 2 tests.
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message