mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 51885: Added a basic default executor implementation.
Date Wed, 14 Sep 2016 13:08:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51885/#review148886
-----------------------------------------------------------



How about rename this file as `default_pod_executor.cpp`?


src/launcher/default_executor.cpp (lines 20 - 22)
<https://reviews.apache.org/r/51885/#comment216396>

    How about adjust the order as following?
    
    ```
    #include <mesos/mesos.hpp>
    
    #include <mesos/executor/executor.hpp>
    ```



src/launcher/default_executor.cpp (line 57)
<https://reviews.apache.org/r/51885/#comment216404>

    How about rename this as `DefaultPodExecutor`?



src/launcher/default_executor.cpp (line 203)
<https://reviews.apache.org/r/51885/#comment216403>

    s/multiple task groups /multiple tasks in task group


- Guangya Liu


On 九月 14, 2016, 9:34 a.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51885/
> -----------------------------------------------------------
> 
> (Updated 九月 14, 2016, 9:34 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-6077
>     https://issues.apache.org/jira/browse/MESOS-6077
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change adds a basic default executor implementation that
> just sends a TASK_RUNNING update followed by a TASK_FINISHED
> update upon the receipt of a LAUNCH_GROUP event from the executor.
> This allows us to test the entire workflow for now. We can iterate
> upon this to later send `LAUNCH_CONTAINER`/`DESTROY_CONTAINER`
> to the agent to actually launch the tasks in a sub container.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 2dd7913a1477f3c3560be4e2c1450b93fb3afc78 
>   src/launcher/default_executor.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/51885/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message