mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 51882: Reverted "Added a test case `ROOT_CGROUPS_CFS_BigQuotaDecimal`.".
Date Wed, 14 Sep 2016 12:55:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51882/#review148898
-----------------------------------------------------------



Patch looks great!

Reviews applied: [51878, 51881, 51882]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Sept. 14, 2016, 3:54 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51882/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2016, 3:54 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, Joseph Wu, and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This reverts commit 6cfa4a6f07f61c9b5edc5cce4b778fdf58baa81a.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/cgroups_tests.cpp 6ebcebbcdda6b829a91f8e04128063a5f02eb48b

> 
> Diff: https://reviews.apache.org/r/51882/diff/
> 
> 
> Testing
> -------
> 
> Refer to @kaysoky's comment https://reviews.apache.org/r/51794/#comment216330 It is no
different between `ROOT_CGROUPS_CFS_Big_Quota` and `ROOT_CGROUPS_CFS_BigQuotaDecimal` if we
use `Duration quota = Milliseconds(100500)`.
> 
> To avoid the compile error in clang, we should revert this.
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message