mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Abhishek Dasgupta <a10gu...@linux.vnet.ibm.com>
Subject Re: Review Request 51501: Exposed metrics in scheduler library.
Date Wed, 14 Sep 2016 11:03:20 GMT


> On Sept. 14, 2016, 12:26 a.m., Anand Mazumdar wrote:
> > src/scheduler/scheduler.cpp, line 744
> > <https://reviews.apache.org/r/51501/diff/2/?file=1492254#file1492254line744>
> >
> >     hmm, this won't quite work for the scheduler library i.e. the messages metric
would always be 0.
> >     
> >     The library uses the `Connection` abstraction that wraps a socket under the
hood and it does not go through the libprocess `MessageEvent` handler route. 
> >     
> >     A possible solution might be to add the metric for messages directly in the
`Connection` abstraction itself?

Yeah, message_queue metric has value of 0 even in case of sched.cpp. i didn't find any MessageEvent
is getting used in scheduler library/driver. May be I am wrong. But message_queue is measured
in old scheduler driver as well so I decided to introduce it though it is having 0 value.


So, as per your comment, as we are sending subscribe.send() call and non-subscribe.send()
call in scheduler library, we can initiate a counter metrics in Connection and increment it
in Connection::send(). Is this the approach we are going to follow?

Also, as message_queue metric is giving 0 value for scheduler driver as well, are we going
to introduce some new logics to collect message metrics there??

I will raise new issues based on your answer.


- Abhishek


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51501/#review148822
-----------------------------------------------------------


On Sept. 6, 2016, 8:53 p.m., Abhishek Dasgupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51501/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2016, 8:53 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-6080
>     https://issues.apache.org/jira/browse/MESOS-6080
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Exposed metrics scheduler/event_queue_messages(size of
> message queue) and scheduler/event_queue_dispatches
> (size of dispatch queue) in scheduler library.
> 
> 
> Diffs
> -----
> 
>   src/scheduler/scheduler.cpp 276ed10bd439c4a7830447bec5053292fb2ca4e7 
>   src/tests/scheduler_tests.cpp 931c1857f1ab454c67eece2f34c4649a426178de 
> 
> Diff: https://reviews.apache.org/r/51501/diff/
> 
> 
> Testing
> -------
> 
> On Ubuntu 16.04
> sudo GTEST_FILTER="*SchedulerTest.MetricsEndpoint*" make -j4 check
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message