mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 49617: Add benchmark for failover of many frameworks.
Date Wed, 14 Sep 2016 08:35:43 GMT


> On 八月 24, 2016, 9:12 a.m., Guangya Liu wrote:
> > src/tests/hierarchical_allocator_tests.cpp, lines 4091-4099
> > <https://reviews.apache.org/r/49617/diff/7/?file=1476268#file1476268line4091>
> >
> >     Can we make sure all of the `allocations` are available when `recoverResources`?
Do we need a `Clock::settle();` after all `suppressOffers` finshed in line 4090?

Looking forward to the updated patch, just want to highlight that adding `Clock::settle` after
`activateFramework` maybe better as we can make sure the all of `allocate()` operations are
finshed before suppress offer. 

The logic could be 
```
activateFramework()

Clock::settle()

suppressOffers()

recoverResources()

Clock::settle()
```


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49617/#review146625
-----------------------------------------------------------


On 八月 17, 2016, 2:26 a.m., Jacob Janco wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49617/
> -----------------------------------------------------------
> 
> (Updated 八月 17, 2016, 2:26 a.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5780
>     https://issues.apache.org/jira/browse/MESOS-5780
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> - This benchmark measures latency to stability of
>   the allocator following disconnection and
>   reconnection of all frameworks.
> - In this scenario, frameworks are offered resources
>   and suppressed in batches.
> 
> 
> Diffs
> -----
> 
>   src/tests/hierarchical_allocator_tests.cpp cbed333f497016fe2811f755028796012b41db77

> 
> Diff: https://reviews.apache.org/r/49617/diff/
> 
> 
> Testing
> -------
> 
> MESOS_BENCHMARK=1 GTEST_FILTER="*BENCHMARK_Test.FrameworkFailover*" make check
> 
> Sample Output:
> [ RUN      ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.FrameworkFailover/23
> Using 10000 agents and 6000 frameworks
> Added 6000 frameworks in 113410us
> Added 10000 agents in 6.83980663333333mins
> allocator settled after  3.28683733333333mins
> [       OK ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.FrameworkFailover/23
(609255 ms)[ RUN      ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.FrameworkFailover/24
> Using 20000 agents and 1 frameworks
> Added 1 frameworks in 190us
> Added 20000 agents in 4.752954secs
> allocator settled after  7us
> [       OK ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.FrameworkFailover/24
(6332 ms)
> 
> 
> Thanks,
> 
> Jacob Janco
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message