mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 51683: Avoided resource validation when flatten resources.
Date Wed, 14 Sep 2016 06:09:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51683/
-----------------------------------------------------------

(Updated 九月 14, 2016, 6:09 a.m.)


Review request for mesos, Benjamin Mahler and Jiang Yan Xu.


Changes
-------

Rebase


Bugs: MESOS-6131
    https://issues.apache.org/jira/browse/MESOS-6131


Repository: mesos


Description
-------

1) Previously if role or reservation info are invalid,
the result is an empty Resources object, now it returns
an error.
2) Added a new flatten() method to flatten resources with
star role and empty reservation.


Diffs (updated)
-----

  include/mesos/resources.hpp 7ba422d57d47777e058c682df9aa780557782423 
  include/mesos/v1/resources.hpp add48c7baf8fabf5cc443d60a6c96d2902fc67de 
  src/cli/execute.cpp c9f56af7f37d5b79b51f350d6c533714c170e889 
  src/common/resources.cpp f841e91b81975a887e64a76a709708ed7946025f 
  src/examples/dynamic_reservation_framework.cpp 850bb2a5b243dd5d5a8b6476570b4f943fde6185

  src/examples/test_framework.cpp a83766a92617d50eadd92ec55113e049a7290d03 
  src/examples/test_http_framework.cpp 441e86c88b035d9a268b8b51b95da3e1eb842a62 
  src/tests/api_tests.cpp e440d1b44fb0b40dd1f68209c71e5ca0cd19f4fb 
  src/tests/hierarchical_allocator_tests.cpp 7705de95a3916310baf4daca62aab1e6b1ca3cb3 
  src/tests/mesos.hpp 92d7d94733d461eb0c565830cc1c8e709e7a2ef7 
  src/tests/persistent_volume_endpoints_tests.cpp 266c2a0ff4a99baa96a7c4980f076755603256a9

  src/tests/reservation_endpoints_tests.cpp bee5ea6b3a3ee7fafb7312a6d89de79d62c57ec1 
  src/tests/reservation_tests.cpp 000957826011bf28f7550a83db3e60a796162fb3 
  src/tests/resources_tests.cpp f627862870279e5a778aa83e1ddcaa88c27ba1cb 
  src/tests/role_tests.cpp 162c9414a70723a212cfd39ac5c0b8325c3f3b5d 
  src/v1/resources.cpp 4410a8f95ef0ebe6ec7aee38cd47f6f83f863867 

Diff: https://reviews.apache.org/r/51683/diff/


Testing
-------

make
make check

```
./bin/mesos-tests.sh  --gtest_filter="ResourcesOperationTest.FlattenResources"
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from ResourcesOperationTest
[ RUN      ] ResourcesOperationTest.FlattenResources
[       OK ] ResourcesOperationTest.FlattenResources (3 ms)
[----------] 1 test from ResourcesOperationTest (3 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (24 ms total)
[  PASSED  ] 1 test.
```


Thanks,

Guangya Liu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message