mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anindya Sinha <anindya_si...@apple.com>
Subject Review Request 51879: Determine disk size when not specified in static resources.
Date Wed, 14 Sep 2016 02:29:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51879/
-----------------------------------------------------------

Review request for mesos and Jiang Yan Xu.


Bugs: MESOS-6062
    https://issues.apache.org/jira/browse/MESOS-6062


Repository: mesos


Description
-------

When static resources indicate disks with a positive size, we use that
for the disk resources on the agent. However, --resources can include
disks with size of 0, which indicates that mesos agent determine the
size of those disks from the host and uses that information instead.
Note that this is not allowed for PATH disks since PATH disks can be
carved into smaller chunks and we cannot assume that the whole
physical disk is available to the PATH disk.

With this change, JSON or textual representation for resources that
specify scalar value of 0 would not result in an error, but those
resources will not be accounted for until a valid size is determined
for such resources. A scalar value of -1 in JSON or textual formats
still results in an invalid resource.


Diffs
-----

  include/mesos/resources.hpp 7ba422d57d47777e058c682df9aa780557782423 
  include/mesos/v1/resources.hpp add48c7baf8fabf5cc443d60a6c96d2902fc67de 
  src/common/resources.cpp f841e91b81975a887e64a76a709708ed7946025f 
  src/slave/containerizer/containerizer.hpp f13669d0dfc4ce3287cfe630cabd0470dc765b51 
  src/slave/containerizer/containerizer.cpp d46882baa904fd439bffb23c324828b777228f1c 
  src/tests/resources_tests.cpp f627862870279e5a778aa83e1ddcaa88c27ba1cb 
  src/v1/resources.cpp 4410a8f95ef0ebe6ec7aee38cd47f6f83f863867 

Diff: https://reviews.apache.org/r/51879/diff/


Testing
-------

Tests passed.


Thanks,

Anindya Sinha


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message