mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 51850: Removed unneeded `Resources::add/remove(const Resource&)`.
Date Wed, 14 Sep 2016 02:03:52 GMT


> On 九月 14, 2016, 12:08 a.m., Guangya Liu wrote:
> > include/mesos/resources.hpp, lines 511-512
> > <https://reviews.apache.org/r/51850/diff/1/?file=1497888#file1497888line511>
> >
> >     I think that we should also mention for how to convert a `Resource` object to
`Resource_` object in the comments of this API, otherwise, people may not know how to add
a `Resource` object.

I posted a patch here for update the comments https://reviews.apache.org/r/51877/


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51850/#review148815
-----------------------------------------------------------


On 九月 13, 2016, 5:04 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51850/
> -----------------------------------------------------------
> 
> (Updated 九月 13, 2016, 5:04 p.m.)
> 
> 
> Review request for mesos, Anindya Sinha and Guangya Liu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We can remove these given that they already call
> `Resources::add/remove(const Resource_&)` internally and
> a Resource is implicitly convertible to a Resource_.
> 
> 
> Diffs
> -----
> 
>   include/mesos/resources.hpp 87828aa5e4818efd40dd72dc199669281b8a15ae 
>   include/mesos/v1/resources.hpp 27bdd275277edc60d97b720e596f21e8e8f8dc27 
>   src/common/resources.cpp 77ee92193de1f34131f7a86b7d16731c9c3e17e2 
>   src/v1/resources.cpp 4ba5bf87c9b9fef67eeb447a3f3b520f1e81ad77 
> 
> Diff: https://reviews.apache.org/r/51850/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message