mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 51794: Added a test case `ROOT_CGROUPS_CFS_BigQuotaDecimal`.
Date Wed, 14 Sep 2016 01:02:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51794/#review148831
-----------------------------------------------------------




src/tests/containerizer/cgroups_tests.cpp (line 532)
<https://reviews.apache.org/r/51794/#comment216330>

    This test is actually equivalent to `ROOT_CGROUPS_CFS_BigQuota`:
    ```
    ../../src/tests/containerizer/cgroups_tests.cpp:532:28: error: implicit conversion from
'double' to 'int64_t' (aka 'long') changes value from 100.5 to 100 [-Werror,-Wliteral-conversion]
      Duration quota = Seconds(100.5); // Big quota with decimal.
    ```
    
    You should use `Duration quota = Milliseconds(100500);` instead, which is technically
a decimal number of seconds.


- Joseph Wu


On Sept. 13, 2016, 2:01 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51794/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2016, 2:01 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add a new test case `ROOT_CGROUPS_CFS_BigQuotaDecimal` to test updating
> CFS quota with decimal.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/cgroups_tests.cpp 821c7860ab424bcfadbf597902e046bce9ba3044

> 
> Diff: https://reviews.apache.org/r/51794/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message