mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 51864: Added logs for container state transitions.
Date Tue, 13 Sep 2016 22:54:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51864/#review148797
-----------------------------------------------------------




src/slave/containerizer/mesos/containerizer.cpp (lines 903 - 904)
<https://reviews.apache.org/r/51864/#comment216312>

    We already have such `LOG(INFO)` in provisioner::_provisioner().
    
    Why do we add this here?


And each isolator should already have similar log info message as well. This would make it
duplicate.

- Gilbert Song


On Sept. 13, 2016, 3:47 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51864/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2016, 3:47 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.cpp dc18e4e3b0eca3f116f1e240217bbebf64a75e3a

> 
> Diff: https://reviews.apache.org/r/51864/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message