mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 51856: Updated agent to correctly populate `CommandInfo` for default executor.
Date Tue, 13 Sep 2016 21:20:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51856/
-----------------------------------------------------------

(Updated Sept. 13, 2016, 9:20 p.m.)


Review request for mesos and Vinod Kone.


Changes
-------

Populated `CommandInfo` with `user` field.


Bugs: MESOS-6151
    https://issues.apache.org/jira/browse/MESOS-6151


Repository: mesos


Description
-------

This change adds the relevant logic to ensure that agent correctly
populates the command info for default executors. Since, we
don't yet have the executable `mesos-default-execute`, added
a `TODO` to the test to add a check to ensure the command
has that information.


Diffs (updated)
-----

  src/slave/constants.hpp 0ad59adc1d44014acd756b87d572e835c6325b5f 
  src/slave/slave.hpp e659c44fcc415f10a6980e7b29cc1ce536dfe657 
  src/slave/slave.cpp 2c7b5ada1aa81babb9ceee0c9f928685878a778c 
  src/tests/slave_tests.cpp 2f3fa5fae634b6250f3c00bbef3077493f79af95 

Diff: https://reviews.apache.org/r/51856/diff/


Testing
-------

make check


Thanks,

Anand Mazumdar


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message