mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joris Van Remoortere <joris.van.remoort...@gmail.com>
Subject Re: Review Request 51511: Added check in FileEncoder's destructor.
Date Tue, 13 Sep 2016 20:11:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51511/#review148771
-----------------------------------------------------------


Ship it!




Ship It!

- Joris Van Remoortere


On Aug. 30, 2016, 1 a.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51511/
> -----------------------------------------------------------
> 
> (Updated Aug. 30, 2016, 1 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Artem Harutyunyan, and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-6104
>     https://issues.apache.org/jira/browse/MESOS-6104
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This check will force libprocess to fail fast if a file descriptor
> is closed underneath it.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/encoder.hpp 9cd0d3f55f2e9c9dc9ebb97b34a23375f8d4e07f 
> 
> Diff: https://reviews.apache.org/r/51511/diff/
> 
> 
> Testing
> -------
> 
> Re-ran the steps in the previous review for several minutes.  Saw that the master did
not CHECK fail.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message