mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Review Request 51855: Cleaned up `getExecutorInfo()` function in the agent.
Date Tue, 13 Sep 2016 19:49:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51855/
-----------------------------------------------------------

Review request for mesos and Vinod Kone.


Repository: mesos


Description
-------

The code was un-necessarily nested thereby making it less readable.
This change returns early if its a custom executor and then moves
all the nested code for command executor out of the `if` block.


Diffs
-----

  src/slave/slave.cpp 2c7b5ada1aa81babb9ceee0c9f928685878a778c 

Diff: https://reviews.apache.org/r/51855/diff/


Testing
-------

make check


Thanks,

Anand Mazumdar


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message