mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 51065: Changed hostname used for SSL cert creation in tests.
Date Tue, 13 Sep 2016 18:00:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51065/#review148746
-----------------------------------------------------------



Looks like this needs a rebase?

- Greg Mann


On Aug. 13, 2016, 6:15 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51065/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2016, 6:15 a.m.)
> 
> 
> Review request for mesos, Joseph Wu and Vinod Kone.
> 
> 
> Bugs: MESOS-3753
>     https://issues.apache.org/jira/browse/MESOS-3753
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This changes the SSL helpers in libprocess to generate
> certs using a hostname determined using the same address
> that is advertised by libprocess. This assures that
> validation of the certificates will succeed. The test
> `SSLTest.BasicSameProcess` is also updated to accommodate
> this change.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/ssl/gtest.hpp 83778bbfcc75f3f39b98d03a3580398e7d1062ea

>   3rdparty/libprocess/src/tests/ssl_tests.cpp a5ac03969694c4345c2c5004051b08b6d1da8555

> 
> Diff: https://reviews.apache.org/r/51065/diff/
> 
> 
> Testing
> -------
> 
> `make check` on Ubuntu 14.04
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message