mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 51707: Fixed races between "unreachable" and "unregister" slave transitions.
Date Tue, 13 Sep 2016 13:25:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51707/
-----------------------------------------------------------

(Updated Sept. 13, 2016, 1:25 p.m.)


Review request for mesos and Vinod Kone.


Changes
-------

Address review comments.


Bugs: MESOS-5965
    https://issues.apache.org/jira/browse/MESOS-5965


Repository: mesos


Description
-------

Now that we update the registry before updating the master's state when
performing these transitions, it is possible for the master to already
be marking a slave unreachable when an `UnregisterSlaveMessage` is
received, or vice versa. Detect these situations and ignore whichever
transition is triggered second.


Diffs (updated)
-----

  src/master/master.cpp 1dcce6cd66804990af238176c61aca03bb5c9471 
  src/tests/slave_tests.cpp 2f3fa5fae634b6250f3c00bbef3077493f79af95 

Diff: https://reviews.apache.org/r/51707/diff/


Testing
-------

make check


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message