mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 51840: Fixed leak of task.
Date Tue, 13 Sep 2016 13:16:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51840/#review148714
-----------------------------------------------------------


Ship it!




Thanks for fixing this.

Ideally, I would like to not create the `Task` object/delete the key from `queuedTasks` on
L6549/L6554 but instead do it in the `else` block on L6569. I would take care of cleaning
it up as part of MESOS-6154 as it would be an orthogonal functional change not related to
fixing the resource leak which this review is concerned with.

- Anand Mazumdar


On Sept. 13, 2016, 9:26 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51840/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2016, 9:26 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-6153
>     https://issues.apache.org/jira/browse/MESOS-6153
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The data structures hold the tasks here uses as raw ptrs which makes
> it hard for users to leverage RAII to avoid leaks. Instead we here now
> create a temporary value, and if needed insert a copy into the task
> list.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp 2c7b5ada1aa81babb9ceee0c9f928685878a778c 
> 
> Diff: https://reviews.apache.org/r/51840/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message