mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Abhishek Dasgupta <a10gu...@linux.vnet.ibm.com>
Subject Re: Review Request 51771: Updated master validation for DOCKER ContainerInfo in TaskGroup.
Date Tue, 13 Sep 2016 10:34:17 GMT


> On Sept. 12, 2016, 8:26 p.m., Vinod Kone wrote:
> > src/master/validation.cpp, lines 1020-1021
> > <https://reviews.apache.org/r/51771/diff/1/?file=1495217#file1495217line1020>
> >
> >     ```
> >     return Error("Docker ContainerInfo is not supported");
> >     ```

Took the liberty of modifying the error message as "Docker ContainerInfo is not supported
on the task" to make consistent with the executor one.


- Abhishek


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51771/#review148575
-----------------------------------------------------------


On Sept. 13, 2016, 10:31 a.m., Abhishek Dasgupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51771/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2016, 10:31 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-6144
>     https://issues.apache.org/jira/browse/MESOS-6144
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> DOCKER as ContainerInfo Type for both task group executor as well as
> taskgroup task is currently not supported. Only MESOS as
> ContainerInfo Type is supported. This patch is to validate that
> TaskGroup executor and tasks do not use DOCKER ContainerInfo.
> 
> 
> Diffs
> -----
> 
>   src/master/validation.cpp 137b9f912029d6b0287b49541d1af9bb1fdb80b3 
>   src/tests/master_validation_tests.cpp 3a5cfa2b8a500c1c9e8af5207ebb91279a61feed 
> 
> Diff: https://reviews.apache.org/r/51771/diff/
> 
> 
> Testing
> -------
> 
> On Ubuntu 16.04:
> sudo make -j`nproc` check
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message