mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 51816: Updated the upgrades.md and CHANGELOG for MESOS-6150.
Date Tue, 13 Sep 2016 08:22:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51816/#review148671
-----------------------------------------------------------




CHANGELOG (line 28)
<https://reviews.apache.org/r/51816/#comment216175>

    Why `Additional` here? What about `API Changes:` directly?



CHANGELOG (lines 29 - 30)
<https://reviews.apache.org/r/51816/#comment216174>

    This depend on /r/51780 . 
    
    In /r/51780 , it is actually `updated recover interface for nested container`.
    
    Using `deprecated` may cause confusion: `deprecated` does not always mean the API is removed
but sometimes may mean this API is in a deprecating cycle.



docs/upgrades.md (line 203)
<https://reviews.apache.org/r/51816/#comment216176>

    Ditto as above, `deprecated` may not fit well in this scenario.


- Guangya Liu


On 九月 12, 2016, 6:45 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51816/
> -----------------------------------------------------------
> 
> (Updated 九月 12, 2016, 6:45 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph Wu, and
Kevin Klues.
> 
> 
> Bugs: MESOS-6150
>     https://issues.apache.org/jira/browse/MESOS-6150
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated the upgrades.md and CHANGELOG for MESOS-6150.
> 
> 
> Diffs
> -----
> 
>   CHANGELOG ef31563e3f4a2ceda598a0ddcc7ad325f64a8538 
>   docs/upgrades.md dc43cad4d9e0bec0f4017ac53d740687c060b332 
> 
> Diff: https://reviews.apache.org/r/51816/diff/
> 
> 
> Testing
> -------
> 
> N/A.
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message