mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 51780: Changed isolator recover interface using 'ContainerRecoverInfo'.
Date Tue, 13 Sep 2016 08:21:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51780/#review148673
-----------------------------------------------------------




include/mesos/slave/isolator.hpp (lines 47 - 48)
<https://reviews.apache.org/r/51780/#comment216177>

    Just a question here, does this interface need a deprecation cycle? This may cause some
customized isolators does not work.


- Guangya Liu


On 九月 12, 2016, 6:41 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51780/
> -----------------------------------------------------------
> 
> (Updated 九月 12, 2016, 6:41 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph Wu, and
Kevin Klues.
> 
> 
> Bugs: MESOS-6150
>     https://issues.apache.org/jira/browse/MESOS-6150
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch changes the isolator::recover interface to use the new
> protobuf message 'ContainerRecoverInfo'. Please see the previous
> commit message for reasons.
> 
> 
> Diffs
> -----
> 
>   include/mesos/slave/isolator.hpp d5880eee3c8aee3555630afd21bdd6af5854d11b 
>   src/slave/containerizer/mesos/containerizer.hpp 078ef4f4e7bf5e1522804a720c51cfa5518d8efd

>   src/slave/containerizer/mesos/containerizer.cpp 1a120f191e4ff0e2b31dd0a9a6bced784a56612c

>   src/slave/containerizer/mesos/isolator.hpp b94947bc5e83b4f2a2174cb21ed559b4241d2c0a

>   src/slave/containerizer/mesos/isolator.cpp 253ff3cea8aff3e7a3051fb5a763cc081f455f18

>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp 38d1428f5425566502747d2a8394e246e0b3fd9e

>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 8b6dfde366caf82d30afb891c8f1337ceed12157

>   src/slave/containerizer/mesos/isolators/cgroups/cpushare.hpp 74982a610b6c0a74734165a0c6aa8c9f72f54deb

>   src/slave/containerizer/mesos/isolators/cgroups/cpushare.cpp 221e814a448c4b5df9dab98de597451a24e2b89c

>   src/slave/containerizer/mesos/isolators/cgroups/devices.hpp 7ad96440b21a380c5d9af27b0168e9abf47769af

>   src/slave/containerizer/mesos/isolators/cgroups/devices.cpp f1b5e75d23780c0e1d53487852422b02c88de9e8

>   src/slave/containerizer/mesos/isolators/cgroups/mem.hpp b3ce6ed2505312bdd2d800164c2f57cd7625c9fa

>   src/slave/containerizer/mesos/isolators/cgroups/mem.cpp 0a4f38ded5cffd438e2a3b1e7d066c3077557f0d

>   src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp 452eeddcf81232174f00afc1f0ddbd410e4540b4

>   src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp dcbc499a7ac60a7be28cd889abc73155a6c1ac83

>   src/slave/containerizer/mesos/isolators/cgroups/perf_event.hpp 4abde12af68a26b94b3706cdb38bf9890d811039

>   src/slave/containerizer/mesos/isolators/cgroups/perf_event.cpp 31f35385691681ef5da14be747edfb5f57c5d05a

>   src/slave/containerizer/mesos/isolators/docker/runtime.hpp ac0397f65bb2a675ad1eae0f7cfa95f10145fc63

>   src/slave/containerizer/mesos/isolators/docker/runtime.cpp b589cd691ae6aacd2dcd00878e43d58f15abfe11

>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp 2cc8e764ff18c95c29598df75cdb370ccf120662

>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp af9f3736b487b595e8768e56ce60dc4823db28a1

>   src/slave/containerizer/mesos/isolators/filesystem/linux.hpp 0a85935550e36c9142d845465cfa70a1634a647a

>   src/slave/containerizer/mesos/isolators/filesystem/linux.cpp ea418252956c8089acc5a491888ed7f6df6cafcd

>   src/slave/containerizer/mesos/isolators/filesystem/posix.hpp 794b6e5990db5f8eb21a6535872f284ca02e0553

>   src/slave/containerizer/mesos/isolators/filesystem/posix.cpp af427c6e5691f1770ab3ebef79502eb2c2176c4a

>   src/slave/containerizer/mesos/isolators/filesystem/shared.cpp a1283e5ee92c916baaf9fca8ce314d597e8421b3

>   src/slave/containerizer/mesos/isolators/gpu/isolator.hpp d94f6cf4da9a06cc0da23294c6fab1ca31920149

>   src/slave/containerizer/mesos/isolators/gpu/isolator.cpp 1383ba2dbb2be99b3eca0f2f62386438827e0bd6

>   src/slave/containerizer/mesos/isolators/namespaces/pid.hpp 1c74ba2561c113c4611577c541b2baed13717ece

>   src/slave/containerizer/mesos/isolators/namespaces/pid.cpp b41e2665e4c9089da55b38aa5d0bedbc1a60e6a8

>   src/slave/containerizer/mesos/isolators/network/cni/cni.hpp eea80355d9a12f7b9571c55194ef3ab4931e6aed

>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 822f11eab5b00c014563322a8c3b2c14cb440e0b

>   src/slave/containerizer/mesos/isolators/network/port_mapping.hpp e852c46a5027c7c911bb7f0c9364ff830f4df086

>   src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 55a06cfe1edbb7699c04101f78cc4979176e33f6

>   src/slave/containerizer/mesos/isolators/posix.hpp 26c693a9a228d41f38854698496612b063baa68c

>   src/slave/containerizer/mesos/isolators/posix/disk.hpp 3998251248ecef2d174f0ea68e0493d09b012952

>   src/slave/containerizer/mesos/isolators/posix/disk.cpp 5b9d5aaeb008e9b102e86736c9312db0b3266d34

>   src/slave/containerizer/mesos/isolators/xfs/disk.hpp 52f0459421a45b01ce38b17c689633301cd97982

>   src/slave/containerizer/mesos/isolators/xfs/disk.cpp 74ffcf5d9899c00b59958897fc9475347fd91160

>   src/tests/containerizer/isolator.hpp fbe80aaf4fe850f4a283b4d07cf09142393e70ba 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 96e24500a12825161553eb050da389088b122695

> 
> Diff: https://reviews.apache.org/r/51780/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message