mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 51782: Entered working directory before switch user.
Date Tue, 13 Sep 2016 05:50:35 GMT


> On Sept. 13, 2016, 4:12 a.m., Jie Yu wrote:
> > Why this change? Any particular reason?
> 
> haosdent huang wrote:
>     Suppose working directory is `/tmp/mesos/sandbox`, if a normal user what to `chdir`
into this folder, that requires that user has `-x` permissions on
>     * /tmp/
>     * /tmp/mesos/
>     * /tmp/mesos/sandox
>     But if we `chdir` before switch user, we could workaround this limit.

Yeah, but is that intended? If a user cannot access a dir, we probably shouldn't chdir?


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51782/#review148645
-----------------------------------------------------------


On Sept. 11, 2016, 4:01 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51782/
> -----------------------------------------------------------
> 
> (Updated Sept. 11, 2016, 4:01 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> If `chdir` into the working directory after switch user, the user may
> fail because of permissions problem.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/launch.cpp b8ad27e987c7bdce800a42140be3125c594e29e8 
> 
> Diff: https://reviews.apache.org/r/51782/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message