mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 51835: Support changing the cgroup owner for command tasks that has rootfs.
Date Tue, 13 Sep 2016 05:32:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51835/#review148659
-----------------------------------------------------------




src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line 425)
<https://reviews.apache.org/r/51835/#comment216164>

    It is guarded by `user.isSome()`


- Jie Yu


On Sept. 13, 2016, 4:59 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51835/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2016, 4:59 a.m.)
> 
> 
> Review request for mesos, haosdent huang and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> For command tasks that have rootfs defined, the command executor will
> be running as root. However, the task might want to manipulate
> cgroups. This patch allows that.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 8b6dfde366caf82d30afb891c8f1337ceed12157

> 
> Diff: https://reviews.apache.org/r/51835/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message