mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 51783: Refactored `UserCgroupsIsolatorTest`.
Date Tue, 13 Sep 2016 04:18:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51783/#review148646
-----------------------------------------------------------




src/tests/containerizer/cgroups_isolator_tests.cpp (line 111)
<https://reviews.apache.org/r/51783/#comment216148>

    'nobody' does not work on my box because it cannot access my home dir, and 'mesos-containerizer
launch' binary needs to be accessible to fork-exec the task.
    
    I think creating a new user does not work either. It previously worked because we don't
use any executable under build dir.
    
    I adjust the test to use an image to bypass the problem, but ran into another problem
that the cgroup owner support only works for custom executor, not command tasks.
    
    For command tasks, since executor is running under root, this test will fail.


- Jie Yu


On Sept. 12, 2016, 8:19 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51783/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2016, 8:19 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Refactor `UserCgroupsIsolatorTest.ROOT_CGROUPS_PERF_UserCgroup` and
> rename to `CgroupsIsolatorTest.ROOT_CGROUPS_PERF_NET_CLS_UserCgroup`.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/cgroups_isolator_tests.cpp c4e467c8227f9e4129b05d173812592f39a04e06

> 
> Diff: https://reviews.apache.org/r/51783/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message