mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 50707: Added test for race between health checks and agent disconnect.
Date Mon, 12 Sep 2016 21:27:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50707/#review148592
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/slave_tests.cpp (line 2810)
<https://reviews.apache.org/r/50707/#comment216045>

    s/disconnects/unregisters/



src/tests/slave_tests.cpp (lines 2869 - 2872)
<https://reviews.apache.org/r/50707/#comment216048>

    It's not clear to me what we are checking to verify that master behaves correctly here?
What would happen if master behaves incorrectly? Maybe add some comments?


- Vinod Kone


On Sept. 7, 2016, 9:29 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50707/
> -----------------------------------------------------------
> 
> (Updated Sept. 7, 2016, 9:29 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4049
>     https://issues.apache.org/jira/browse/MESOS-4049
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This test tries to simulate a race between marking an agent unhealthy
> and receiving an `UnregisterSlaveMessage` for that agent.
> 
> Unfortunately, this test is a little fragile (we need to manually
> dispatch an event to the master process to simulate the action that
> would be taken by the slave observer).
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_tests.cpp 701fab20091f9f7df020290b9f0a9db1dec92647 
> 
> Diff: https://reviews.apache.org/r/50707/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message