mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 51475: Added an equality operator for `TaskGroupInfo`.
Date Mon, 12 Sep 2016 20:21:11 GMT


> On Sept. 8, 2016, 8:46 a.m., Vinod Kone wrote:
> > No unit tests for this?

hmm, I had punted on this due to not able to find the corresponding test file for type utils.
I added a new file for type utils tests explicitly now.


> On Sept. 8, 2016, 8:46 a.m., Vinod Kone wrote:
> > src/common/type_utils.cpp, lines 401-402
> > <https://reviews.apache.org/r/51475/diff/3/?file=1493736#file1493736line401>
> >
> >     this shouldn't be serialize either. can you add a TODO for adding equality operator
for TaskInfo as well?

Added an explicit trivial equality operator that just invokes `SerializeAsString()` for `TaskInfo`.


- Anand


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51475/#review148160
-----------------------------------------------------------


On Sept. 7, 2016, 9:53 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51475/
> -----------------------------------------------------------
> 
> (Updated Sept. 7, 2016, 9:53 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-6076
>     https://issues.apache.org/jira/browse/MESOS-6076
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is needed for storing `TaskGroupInfo` in a list and then
> invoking `std::find()`/`std::remove()` on it.
> 
> Review: https://reviews.apache.org/r/51475/
> 
> 
> Diffs
> -----
> 
>   include/mesos/type_utils.hpp d10b66345e1a70801050d2cf2db63d76fbf9bc8c 
>   src/common/type_utils.cpp c7d50334b4e56bc0eb5473b9f9277465b607334f 
> 
> Diff: https://reviews.apache.org/r/51475/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message