mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 51152: Moved MockDocker and related declarations to separate files.
Date Mon, 12 Sep 2016 19:08:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51152/#review148560
-----------------------------------------------------------



Patch looks great!

Reviews applied: [51148, 51149, 51150, 51151, 51808, 51152]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Sept. 12, 2016, 2:43 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51152/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2016, 2:43 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Moved MockDocker and related declarations to separate files.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am fa71381741083d3148ddaec715a862d65fc5c990 
>   src/tests/container_logger_tests.cpp a2dc126ce6649066a89e5db2f6f66a1a9fcf3eb4 
>   src/tests/containerizer/docker_containerizer_tests.cpp 28cd3fa66886dbdbae3fdeca77707147faafcb7a

>   src/tests/containerizer/docker_volume_isolator_tests.cpp 236834e20c21c9ff6b44a7a675098a90d1b8d9dd

>   src/tests/health_check_tests.cpp 50a252b5267cbc3b21ddc75e1da86c4975f6faf1 
>   src/tests/hook_tests.cpp d864ef3d6153dedab8cc47403b1b9f76d75aeb5c 
>   src/tests/mesos.hpp 9bcdaf19833d08ccfbfe4781179f8626e141a7e1 
>   src/tests/mesos.cpp f5034f9f8de7040182e10f51be125a87b29fdd24 
>   src/tests/mock_docker.hpp PRE-CREATION 
>   src/tests/mock_docker.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/51152/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message