mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Silas Snider <swsni...@apple.com>
Subject Re: Review Request 51803: Ensured `HealthCheck::HTTPCheckInfo` compatible with the old one.
Date Mon, 12 Sep 2016 17:49:53 GMT


> On Sept. 12, 2016, 5:23 p.m., Silas Snider wrote:
> > include/mesos/mesos.proto, line 374
> > <https://reviews.apache.org/r/51803/diff/3/?file=1496755#file1496755line374>
> >
> >     Why is this being deprecated when the comment above mentions needing to support
it?
> 
> haosdent huang wrote:
>     @swsnider, we may not support this in this form. And it is not supported in HTTP
health check now indeed. So mark it deprecated here.

Cool, that makes sense. I'll see if we can have a conversation about this on the mailing list,
but that shouldn't block this change.


- Silas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51803/#review148521
-----------------------------------------------------------


On Sept. 12, 2016, 2 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51803/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2016, 2 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Joseph Wu, Silas Snider, and Jiang Yan
Xu.
> 
> 
> Bugs: MESOS-6110
>     https://issues.apache.org/jira/browse/MESOS-6110
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Ensured `HealthCheck::HTTPCheckInfo` compatible with the old one.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto eb61b6243202464da2307d06d80700f19f9c25d4 
>   include/mesos/v1/mesos.proto 62231522f4bfddfc6c440a299dd01080cbe25f6a 
> 
> Diff: https://reviews.apache.org/r/51803/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message