mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <>
Subject Re: Review Request 51653: Handled agents failing health checks multiple times.
Date Mon, 12 Sep 2016 16:01:37 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Sept. 12, 2016, 4:01 p.m.)

Review request for mesos and Vinod Kone.



Bugs: MESOS-5965

Repository: mesos


Now that we wait for the agent to be removed from the registry before
stopping the SlaveObserver, it is possible for an agent to fail health
checks multiple times if the registry operation takes longer than

This commit updates the master logic to handle this by ignoring health
check failures while the registry operation to mark the agent
unreachable is still in progress.

Diffs (updated)

  src/master/master.cpp 1dcce6cd66804990af238176c61aca03bb5c9471 
  src/tests/partition_tests.cpp f3142ad8d50daafcdb70ad9dbb2772f8ba30db00 



make check on OSX and Linux.

`./src/mesos-tests --gtest_filter="Strict/PartitionTest.FailHealthChecksTwice/0" --gtest_repeat=1000


Neil Conway

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message