mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <>
Subject Re: Review Request 51375: Introduced MockRegistrar.
Date Mon, 12 Sep 2016 14:49:13 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Sept. 12, 2016, 2:49 p.m.)

Review request for mesos and Vinod Kone.


Fix `make distcheck` error with newly added header file `mock_registrar.hpp`

Bugs: MESOS-4049

Repository: mesos


This allows test cases to inspect how the master interacts with
the registry.

This commit changes `tests::cluster::Master` to use `MockRegistrar`
exclusively, even for test cases that aren't interested in mocking
aspects of the master <-> registrar interaction. However, this should be
harmless, since by default `MockRegistrar` behaves identically to the
normal registrar.

Diffs (updated)

  src/ fa71381741083d3148ddaec715a862d65fc5c990 
  src/master/registrar.hpp c39dd1b5430084e51376143b5441db346e85a153 
  src/tests/cluster.hpp c6fbbf24e04c38cc9a94ce0c13db445c03e804c7 
  src/tests/cluster.cpp b04653af97d17aaa9d0d3ee872169b66cd67126b 
  src/tests/mock_registrar.hpp PRE-CREATION 
  src/tests/mock_registrar.cpp PRE-CREATION 



make check


Neil Conway

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message