mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 51148: Moved MockSlave into a separate header/implementation file.
Date Mon, 12 Sep 2016 14:36:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51148/
-----------------------------------------------------------

(Updated Sept. 12, 2016, 2:36 p.m.)


Review request for mesos and Michael Park.


Changes
-------

Fix `mock_slave.hpp` for `make distcheck`.


Repository: mesos


Description
-------

This improves compilation time for the unit tests. There is also
merit in moving related declarations together into a separate,
smaller header file.


Diffs (updated)
-----

  src/Makefile.am fa71381741083d3148ddaec715a862d65fc5c990 
  src/tests/mesos.hpp 9bcdaf19833d08ccfbfe4781179f8626e141a7e1 
  src/tests/mesos.cpp f5034f9f8de7040182e10f51be125a87b29fdd24 
  src/tests/mock_slave.hpp PRE-CREATION 
  src/tests/mock_slave.cpp PRE-CREATION 
  src/tests/oversubscription_tests.cpp 18da40e92a2717e9729c300799a4790bba379906 
  src/tests/persistent_volume_tests.cpp d07ff1fd2f14c73c924a07ce3850bf0d9de2135a 
  src/tests/reservation_tests.cpp 000957826011bf28f7550a83db3e60a796162fb3 
  src/tests/slave_tests.cpp 701fab20091f9f7df020290b9f0a9db1dec92647 

Diff: https://reviews.apache.org/r/51148/diff/


Testing
-------

make check


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message