mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 51152: Moved MockDocker and related declarations to separate files.
Date Mon, 12 Sep 2016 14:23:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51152/#review148495
-----------------------------------------------------------


Ship it!




I think we need to add `mock_docker.hpp` into `Makefile.am` as well in order for `make distcheck`
to work properly.

- Michael Park


On Aug. 16, 2016, 9:04 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51152/
> -----------------------------------------------------------
> 
> (Updated Aug. 16, 2016, 9:04 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Moved MockDocker and related declarations to separate files.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am d389e02584cfb1a00067cd30de1364118d1c46c7 
>   src/tests/container_logger_tests.cpp efadceafca5721bce4dbffadb35f54fd5365abb0 
>   src/tests/containerizer/docker_containerizer_tests.cpp 42d4364b6fcbc94c7852721511001c103cb5a90d

>   src/tests/containerizer/docker_volume_isolator_tests.cpp da96f8646874df31729783416ab9bfad282696c7

>   src/tests/health_check_tests.cpp e69c4f5cc4756f4926e67ce5e9bbd7ab17e41913 
>   src/tests/hook_tests.cpp ac1188e29ca513e99b7a4b8b633cb8ee86469230 
>   src/tests/master_allocator_tests.cpp 7eed672be14f116d0aa5058da98a1db3a146dad9 
>   src/tests/mesos.hpp 4cae54b4df906d4b7e8fe8d40d5b0ad59d260e6f 
>   src/tests/mesos.cpp 62e8fcc6fa7bd856aab6148ca6e6cad66b436f04 
>   src/tests/mock_docker.hpp PRE-CREATION 
>   src/tests/mock_docker.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/51152/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message