mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 51150: Cleaned up usage of namespace-qualified identifiers.
Date Mon, 12 Sep 2016 14:10:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51150/#review148490
-----------------------------------------------------------


Ship it!




Ship It!

- Michael Park


On Aug. 16, 2016, 9:04 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51150/
> -----------------------------------------------------------
> 
> (Updated Aug. 16, 2016, 9:04 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> If a file contains "using foo::bar", the remainder of the file
> should generally use "bar", rather than "foo::bar" (or worse, a mix
> of "foo::bar" and "bar").
> 
> 
> Diffs
> -----
> 
>   src/common/http.cpp 65e73235a95c1129a7e51a64077eb6ed2aee4a4b 
>   src/docker/executor.cpp 8d679cd33b6ddf3a5c11bb8c458a97b8809473ac 
>   src/linux/fs.cpp 0d025d31a2947920517f9c8abfc14dd4af0c73d0 
>   src/local/local.cpp 1e1d246790a0d44d1baf802b903dc4f2bde1ac63 
>   src/master/allocator/mesos/hierarchical.cpp 234ef98529964a0b6d3f132426a6c8ccbb1263ee

>   src/master/allocator/sorter/drf/metrics.cpp c793f3216287fd40998a1d4aab016d55aa1ac151

>   src/master/http.cpp 52dd80b856cf2317c0b73ba54bf501696786088d 
>   src/master/weights_handler.cpp 9a901e71ba2fbf2ca1c02f658a72d44cfaa5ec62 
>   src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp bebefbba7153d4b0e9a8d7179cfb642e6e802bea

>   src/slave/containerizer/mesos/isolators/docker/volume/driver.cpp 842f2b5d4037e076cac4fd9c2eeb8f69786cffa7

>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 760d32bf3dc09f3b715b378f5ded41556f15fe41

>   src/slave/containerizer/mesos/isolators/xfs/disk.cpp 60e849322ff755e00eced1b80adadb47bf964cbf

>   src/slave/containerizer/mesos/isolators/xfs/utils.cpp e7ee466f7b5aedb08cc7b8c72f091892721ae239

>   src/slave/containerizer/mesos/launch.cpp 2db8db5ac2f4614d406b950a1b4e8098a0d90e7b 
>   src/slave/containerizer/mesos/provisioner/appc/cache.cpp e075e488c03d20c7b78e1969ea76e95b89fb7cfa

>   src/slave/slave.cpp 0feb5c5b6498fe2627a9239b2c1aea78f1c57e49 
>   src/tests/containerizer/xfs_quota_tests.cpp 243ef33686059f3ef46f0c29cc59fa2a79d4ba5b

>   src/tests/dynamic_weights_tests.cpp 88565d19146c9f8fc26808a62e4a67ced1b2a5f3 
>   src/tests/files_tests.cpp 78719da5938ff0de722f8411174817f708fd41f2 
>   src/tests/log_tests.cpp 146a2dc8d54c06fa0a885a4760c45d5a10492128 
>   src/tests/mesos.cpp 62e8fcc6fa7bd856aab6148ca6e6cad66b436f04 
>   src/tests/mock_slave.cpp PRE-CREATION 
>   src/tests/partition_tests.cpp 0a72b345538ca3b9510fccf38ceb68ac71c2b473 
>   src/tests/resources_tests.cpp e61bdeffd5114ab481903c1178d9ecb3452ec85b 
>   src/tests/slave_recovery_tests.cpp b6d4ae54e327ece18263e11cb7ca01fb832a5da4 
> 
> Diff: https://reviews.apache.org/r/51150/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message