mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 51803: Ensured `HealthCheck::HTTPCheckInfo` compatible with the old one.
Date Mon, 12 Sep 2016 13:54:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51803/#review148484
-----------------------------------------------------------




include/mesos/mesos.proto (lines 358 - 359)
<https://reviews.apache.org/r/51803/#comment215929>

    We remove the default, but it should be fine, since we allow `path` to be unset.



include/mesos/mesos.proto (lines 360 - 362)
<https://reviews.apache.org/r/51803/#comment215932>

    No need to move these lines down. It's fine that tag `3` comes before `1`.



include/mesos/mesos.proto (lines 372 - 374)
<https://reviews.apache.org/r/51803/#comment215930>

    Let's be more explicit about deprecation:
    // NOTE: This field will be deprecated in Mesos 2.0. Setting this field has no effect
if any of the default executors is used.



include/mesos/mesos.proto (line 419)
<https://reviews.apache.org/r/51803/#comment215931>

    We must restore the `1` tag, right?


- Alexander Rukletsov


On Sept. 12, 2016, 1:17 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51803/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2016, 1:17 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Joseph Wu, Silas Snider, and Jiang Yan
Xu.
> 
> 
> Bugs: MESOS-6110
>     https://issues.apache.org/jira/browse/MESOS-6110
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Ensured `HealthCheck::HTTPCheckInfo` compatible with the old one.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto eb61b6243202464da2307d06d80700f19f9c25d4 
>   include/mesos/v1/mesos.proto 62231522f4bfddfc6c440a299dd01080cbe25f6a 
> 
> Diff: https://reviews.apache.org/r/51803/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message