mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 51560: Updated HealthCheck protobuf message for backwards compatibility.
Date Mon, 12 Sep 2016 10:28:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51560/
-----------------------------------------------------------

(Updated Sept. 12, 2016, 10:28 a.m.)


Review request for mesos, Alexander Rukletsov, Joseph Wu, Silas Snider, and Jiang Yan Xu.


Changes
-------

Rebase.


Bugs: MESOS-6110
    https://issues.apache.org/jira/browse/MESOS-6110


Repository: mesos


Description
-------

Revert the changes about `HealthCheck::HTTP` and use `HTTP_NEW` as the
new HTTP health check type to avoid breaking backwards compatibility.
In this patch, deprecated using health checks without setting the type
as well.


Diffs (updated)
-----

  CHANGELOG ef31563e3f4a2ceda598a0ddcc7ad325f64a8538 
  docs/upgrades.md dc43cad4d9e0bec0f4017ac53d740687c060b332 
  include/mesos/mesos.proto eb61b6243202464da2307d06d80700f19f9c25d4 
  include/mesos/v1/mesos.proto 62231522f4bfddfc6c440a299dd01080cbe25f6a 
  src/docker/executor.cpp f5981b080c0b81ef7025527ab26b36d7a01f009b 
  src/health-check/health_checker.cpp f373df19fc8af8e9650be61e3b101e89362a67cd 
  src/tests/health_check_tests.cpp 50a252b5267cbc3b21ddc75e1da86c4975f6faf1 

Diff: https://reviews.apache.org/r/51560/diff/


Testing
-------

Could verfied from https://github.com/haosdent/mesos/blob/85abb6da058bf8daf4e794df7da8eb5f240b671c/docs/upgrades.md


Thanks,

haosdent huang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message