mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhang...@cn.ibm.com>
Subject Re: Review Request 51631: Tracked recovered and prepared cgroups subsystems for containers.
Date Mon, 12 Sep 2016 03:09:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51631/#review148440
-----------------------------------------------------------



I think this patch is mainly for handling the case that agent is restarted with more cgroups
subsystems enabled, but what if the agent is restarted with less cgroups subsystems enabled?
In this case, it seems we may miss to destroy some cgroups when a container is cleaned up.

- Qian Zhang


On Sept. 12, 2016, 10:49 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51631/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2016, 10:49 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Qian Zhang.
> 
> 
> Bugs: MESOS-6063
>     https://issues.apache.org/jira/browse/MESOS-6063
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Recover newly added cgroups subsystems on existing containers would
> fail, and continue to perform the `update` and other operations of
> the newly added subsystems on them don't make sense. This patch add
> the tracking for the recovered or prepared cgroups subsystems of a
> container and skip performing unnecessary subsystem operations on the
> container if the subsystem is never recovered or prepared.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp 38d1428f5425566502747d2a8394e246e0b3fd9e

>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 8b6dfde366caf82d30afb891c8f1337ceed12157

> 
> Diff: https://reviews.apache.org/r/51631/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message