mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Yongqiao Wang <grady.w...@foxmail.com>
Subject Re: Review Request 51493: Add the query parameter in createRequest.
Date Mon, 12 Sep 2016 00:59:01 GMT


> On 九月 11, 2016, 5:26 p.m., haosdent huang wrote:
> > 3rdparty/libprocess/include/process/http.hpp, line 845
> > <https://reviews.apache.org/r/51493/diff/1/?file=1487972#file1487972line845>
> >
> >     I think use `hashmap` as type here would be better?

Thank haosdent for your comments, to keep the interface consistence with `http:get(const UPID&
upid,const Option<string>& path, const Option<string>& query,const Option<Headers>&
headers)`, I also use `Option<std::string>&` in `createRequest` function, then all
the caller will have the small changes to call `createRequest`. I quite agree with you to
change this to `hashmap` to avoid the input error in format, and we can submit another patch
after clean all http:get function.


- Yongqiao


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51493/#review148428
-----------------------------------------------------------


On 八月 29, 2016, 10:47 p.m., Yongqiao Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51493/
> -----------------------------------------------------------
> 
> (Updated 八月 29, 2016, 10:47 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-4440
>     https://issues.apache.org/jira/browse/MESOS-4440
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add the new 'query' parameter in createRequest method, which will be used by Http GET
method later.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/http.hpp 404196bb198c1ff958b55d72fb29c5fe92dba429

>   3rdparty/libprocess/src/http.cpp 298bd460afdeccd18e201d8a505b961fd4cf3d3e 
> 
> Diff: https://reviews.apache.org/r/51493/diff/
> 
> 
> Testing
> -------
> 
> make & make check successfully.
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message