mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 51668: Changed the nested ContainerID from hashmap to list in memory.
Date Sun, 11 Sep 2016 23:44:31 GMT


> On Sept. 6, 2016, 11:16 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/containerizer.hpp, line 333
> > <https://reviews.apache.org/r/51668/diff/1/?file=1492306#file1492306line333>
> >
> >     Any reason not use a 'vector'?

IN fact, why not use hashset here?


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51668/#review147941
-----------------------------------------------------------


On Sept. 10, 2016, 10:15 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51668/
> -----------------------------------------------------------
> 
> (Updated Sept. 10, 2016, 10:15 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph Wu, and
Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Changed the nested ContainerID from hashmap to list in memory.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.hpp 078ef4f4e7bf5e1522804a720c51cfa5518d8efd

> 
> Diff: https://reviews.apache.org/r/51668/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message