mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhang...@cn.ibm.com>
Subject Re: Review Request 51781: Updated `NetClsCgroupsFilter` to use `NET_CLS_` to filter test cases.
Date Sun, 11 Sep 2016 14:28:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51781/#review148421
-----------------------------------------------------------




src/tests/environment.cpp (line 438)
<https://reviews.apache.org/r/51781/#comment215881>

    I would suggest to still use test fixture name rather than test name to do the filter,
please see my comment https://reviews.apache.org/r/51783/#comment215876 for more details.


- Qian Zhang


On Sept. 11, 2016, 6:30 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51781/
> -----------------------------------------------------------
> 
> (Updated Sept. 11, 2016, 6:30 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated `NetClsCgroupsFilter` to use `NET_CLS_` to filter test cases.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/isolator_tests.cpp f8056ca08029feed5f164d4f94e24d521183bdfc

>   src/tests/environment.cpp 7f144f1763320aef1657a60b293d585b74a83367 
> 
> Diff: https://reviews.apache.org/r/51781/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message