mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhang...@cn.ibm.com>
Subject Re: Review Request 51783: Refactored `UserCgroupsIsolatorTest`.
Date Sun, 11 Sep 2016 14:22:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51783/#review148420
-----------------------------------------------------------




src/tests/containerizer/cgroups_isolator_tests.cpp (line 91)
<https://reviews.apache.org/r/51783/#comment215876>

    The test name `ROOT_CGROUPS_PERF_NET_CLS_UserCgroup` seems a bit weird to me, if we follow
this way, we may need to name it as `ROOT_CGROUPS_CPU_DEVICES_MEM_PERF_NET_CLS_UserCgroup`
since `cgroups/cpu`, `cgroups/devices` and `cgroups/mem` are also enabled in this case, that
is obviouly a too long test name :-)
    
    So I am thinking maybe we just name it as `ROOT_CGROUPS_UserCgroup`, and in https://reviews.apache.org/r/51781,
we can still do the filter based on test fixture name rather than test name, like this:
    ```
        if (matches(test, "NetClsIsolatorTest") ||
            matches(test, "UserCgroupsIsolatorTest") {
          return netClsError;
        }
    ```



src/tests/containerizer/cgroups_isolator_tests.cpp (lines 133 - 137)
<https://reviews.apache.org/r/51783/#comment215877>

    Can we use `createTask()` instead?



src/tests/containerizer/cgroups_isolator_tests.cpp (line 141)
<https://reviews.apache.org/r/51783/#comment215878>

    I do not think we need this since it is `true` by default.



src/tests/containerizer/cgroups_isolator_tests.cpp (line 156)
<https://reviews.apache.org/r/51783/#comment215879>

    I think we can just use vector.


- Qian Zhang


On Sept. 11, 2016, 6:31 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51783/
> -----------------------------------------------------------
> 
> (Updated Sept. 11, 2016, 6:31 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Refactored `UserCgroupsIsolatorTest`.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/cgroups_isolator_tests.cpp c4e467c8227f9e4129b05d173812592f39a04e06

>   src/tests/containerizer/isolator_tests.cpp f8056ca08029feed5f164d4f94e24d521183bdfc

> 
> Diff: https://reviews.apache.org/r/51783/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message