mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 51770: Changed provisioner recover interface for nested support.
Date Sun, 11 Sep 2016 01:29:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51770/#review148408
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/containerizer/mesos/provisioner/provisioner.cpp (line 165)
<https://reviews.apache.org/r/51770/#comment215867>

    recover known containers and destroy unknown ones



src/slave/containerizer/mesos/provisioner/provisioner.cpp (lines 170 - 171)
<https://reviews.apache.org/r/51770/#comment215868>

    NOTE: All containers, including top level container and child containers, will be included
in the hashset.



src/slave/containerizer/mesos/provisioner/provisioner.cpp (lines 183 - 184)
<https://reviews.apache.org/r/51770/#comment215869>

    I'd remove the second sentense. YOu already mentioned above.



src/slave/containerizer/mesos/provisioner/provisioner.cpp (lines 229 - 231)
<https://reviews.apache.org/r/51770/#comment215870>

    I'd remove from `However, ..."


- Jie Yu


On Sept. 9, 2016, 8:07 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51770/
> -----------------------------------------------------------
> 
> (Updated Sept. 9, 2016, 8:07 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph Wu, and
Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The current interface for provisioner::recover() is not sufficient
> for provisioner to recognize unknown nested containers. For
> instance, to support provisioner nested aware, an alive top level
> executor container may container nested containers which are not
> forked yet. Currently, the ContainerState list and orphans set are
> not enough to find out unknown nested containers.
> 
> The launcher is responsible to return all known containers (from
> all hierarchy). This simplifies the logic in provisioner/isolator
> recover.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.cpp 89b7e8db38916d69d9b2d4fe305d4397b0859a10

>   src/slave/containerizer/mesos/provisioner/provisioner.hpp 64cfa50ba3ae1563dd2ca1f13656ec02bb655038

>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 8e35ff49ec99a242e764095dcfbb541c5e41ec71

>   src/tests/containerizer/mesos_containerizer_tests.cpp 72346c748598e4c0787dba09d9ccb59f244b0df5

>   src/tests/containerizer/provisioner_appc_tests.cpp b3ba176e506a6d1528290c07a8a0555b12c8cf70

> 
> Diff: https://reviews.apache.org/r/51770/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message