mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Review Request 51784: Supported merging the launch command from isolators.
Date Sun, 11 Sep 2016 00:17:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51784/
-----------------------------------------------------------

Review request for mesos, Benjamin Bannier and Gilbert Song.


Bugs: MESOS-5275
    https://issues.apache.org/jira/browse/MESOS-5275


Repository: mesos


Description
-------

Previously, we only allow one isolator to specify the launch command
for the container. This is not ideal because multiple isolators might
want to add some flags to the command executor. For instance, the
'docker/runtime' isolator wants to specify '--task_command' and
'--working_directory', and 'linux/capabilities' isolator wants to
specify '--capabilities'.

This patch changes the semantics so that launch command from isolators
are merged. However, it is isolator's responsibility to make sure the
merged command is a valid command.


Diffs
-----

  src/slave/containerizer/mesos/containerizer.cpp 89b7e8db38916d69d9b2d4fe305d4397b0859a10


Diff: https://reviews.apache.org/r/51784/diff/


Testing
-------

make check


Thanks,

Jie Yu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message