mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 51771: Updated master validation for DOCKER ContainerInfo in TaskGroup.
Date Sat, 10 Sep 2016 04:00:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51771/#review148397
-----------------------------------------------------------




src/master/validation.cpp (line 1021)
<https://reviews.apache.org/r/51771/#comment215854>

    kill the period at the end



src/master/validation.cpp (line 1085)
<https://reviews.apache.org/r/51771/#comment215855>

    kill the period at the end



src/tests/master_validation_tests.cpp (line 1722)
<https://reviews.apache.org/r/51771/#comment215850>

    s/ContainerInfo Type/`ContainerInfo`
    s/DOCKER/`DOCKER`



src/tests/master_validation_tests.cpp (line 1724)
<https://reviews.apache.org/r/51771/#comment215856>

    s/ExecutorWithDockerContainerInfo/ExecutorUseDockerContainerInfo



src/tests/master_validation_tests.cpp (line 1751)
<https://reviews.apache.org/r/51771/#comment215857>

    s/.get()./->



src/tests/master_validation_tests.cpp (line 1753)
<https://reviews.apache.org/r/51771/#comment215851>

    ditto



src/tests/master_validation_tests.cpp (lines 1797 - 1798)
<https://reviews.apache.org/r/51771/#comment215849>

    Suggest put the blank space at the beginning of the new line, ditto for others.
    
    ```
    "DOCKER ContainerInfo is not supported in task group executors. Only"
    " MESOS ContainerInfo is supported now.",
    ```



src/tests/master_validation_tests.cpp (line 1894)
<https://reviews.apache.org/r/51771/#comment215852>

    I think that we can kill `Type` here



src/tests/master_validation_tests.cpp (line 1928)
<https://reviews.apache.org/r/51771/#comment215853>

    s/ContainerInfo Type/`ContainerInfo`
    s/DOCKER/`DOCKER`


- Guangya Liu


On 九月 9, 2016, 8:21 p.m., Abhishek Dasgupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51771/
> -----------------------------------------------------------
> 
> (Updated 九月 9, 2016, 8:21 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-6144
>     https://issues.apache.org/jira/browse/MESOS-6144
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> DOCKER as ContainerInfo Type for both task group executor as well as
> taskgroup task is currently not supported. Only MESOS as
> ContainerInfo Type is supported. This patch is to validate that
> TaskGroup executor and tasks do not use DOCKER ContainerInfo.
> 
> 
> Diffs
> -----
> 
>   src/master/validation.cpp 137b9f912029d6b0287b49541d1af9bb1fdb80b3 
>   src/tests/master_validation_tests.cpp 3a5cfa2b8a500c1c9e8af5207ebb91279a61feed 
> 
> Diff: https://reviews.apache.org/r/51771/diff/
> 
> 
> Testing
> -------
> 
> On Ubuntu 16.04:
> sudo make -j`nproc` check
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message