mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 49617: Add benchmark for failover of many frameworks.
Date Sat, 10 Sep 2016 01:30:16 GMT


> On 九月 9, 2016, 7:06 a.m., Guangya Liu wrote:
> > src/tests/hierarchical_allocator_tests.cpp, line 4035
> > <https://reviews.apache.org/r/49617/diff/7/?file=1476268#file1476268line4035>
> >
> >     You can call ` SlaveInfo createSlaveInfo(const Resources& resources)` so
as to avoid calling `Resources::parse()` each time.
> 
> Jacob Janco wrote:
>     We want a unique slaveId for each per: `slaveId.set_value("agent" + stringify(nextSlaveId++));`
in createSlaveInfo

I think that the API `SlaveInfo createSlaveInfo(const Resources& resources)` can also
keep a unique slaveId for each agent here https://github.com/apache/mesos/blob/master/src/tests/hierarchical_allocator_tests.cpp#L239-L249
, comments?


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49617/#review148311
-----------------------------------------------------------


On 八月 17, 2016, 2:26 a.m., Jacob Janco wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49617/
> -----------------------------------------------------------
> 
> (Updated 八月 17, 2016, 2:26 a.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5780
>     https://issues.apache.org/jira/browse/MESOS-5780
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> - This benchmark measures latency to stability of
>   the allocator following disconnection and
>   reconnection of all frameworks.
> - In this scenario, frameworks are offered resources
>   and suppressed in batches.
> 
> 
> Diffs
> -----
> 
>   src/tests/hierarchical_allocator_tests.cpp cbed333f497016fe2811f755028796012b41db77

> 
> Diff: https://reviews.apache.org/r/49617/diff/
> 
> 
> Testing
> -------
> 
> MESOS_BENCHMARK=1 GTEST_FILTER="*BENCHMARK_Test.FrameworkFailover*" make check
> 
> Sample Output:
> [ RUN      ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.FrameworkFailover/23
> Using 10000 agents and 6000 frameworks
> Added 6000 frameworks in 113410us
> Added 10000 agents in 6.83980663333333mins
> allocator settled after  3.28683733333333mins
> [       OK ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.FrameworkFailover/23
(609255 ms)[ RUN      ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.FrameworkFailover/24
> Using 20000 agents and 1 frameworks
> Added 1 frameworks in 190us
> Added 20000 agents in 4.752954secs
> allocator settled after  7us
> [       OK ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.FrameworkFailover/24
(6332 ms)
> 
> 
> Thanks,
> 
> Jacob Janco
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message