mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 51402: Added nested container check in provisioner destroy.
Date Fri, 09 Sep 2016 22:13:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51402/#review148380
-----------------------------------------------------------


Ship it!




Suggestion for description:
```
This forces the agent to fail fast if we attempt to destroy an outer
container without first destroying all nested containers.  It is
appropriate to CHECK as we control all the call sites.
```


src/slave/containerizer/mesos/provisioner/provisioner.cpp (lines 424 - 426)
<https://reviews.apache.org/r/51402/#comment215838>

    Rewording a bit:
    ```
    // In the above cases, we assume that the container being destroyed
    // has no corresponding nested containers. We fail fast if this
    // condition is not satisfied.
    ```



src/slave/containerizer/mesos/provisioner/provisioner.cpp (lines 428 - 431)
<https://reviews.apache.org/r/51402/#comment215839>

    Rewording a bit:
    ```
    // NOTE: This check is expensive since it traverses the entire
    // `infos` hashmap. This is acceptable because we generally expect
    // the number of containers on a single agent to be on the order of
    // tens or hundreds of containers.
    ```


- Joseph Wu


On Sept. 9, 2016, 1:07 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51402/
> -----------------------------------------------------------
> 
> (Updated Sept. 9, 2016, 1:07 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph Wu, and
Kevin Klues.
> 
> 
> Bugs: MESOS-6067
>     https://issues.apache.org/jira/browse/MESOS-6067
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Please see the comments in the patch for detail.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 8e35ff49ec99a242e764095dcfbb541c5e41ec71

> 
> Diff: https://reviews.apache.org/r/51402/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message